Skip to content

Conversation

@a-maurice
Copy link
Collaborator

Description

Provide details of the change, and generalize the change in the PR title above.

Imagen 4 has a lower rate limit, so disable some of the tests on CI.


Testing

Describe how you've tested these changes.

Running locally


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a targeted modification to the CI test suite by conditionally disabling specific Imagen-related tests. The primary motivation is to mitigate issues arising from Imagen 4's lower rate limits, ensuring that the CI pipeline can execute without encountering rate-limit-induced failures or delays. This adjustment helps maintain the stability and efficiency of the automated testing process.

Highlights

  • CI Test Disablement: Two Imagen-related tests, TestImagenGenerateImage and TestTemplateImagenGenerateImage, have been conditionally disabled from running in the Continuous Integration (CI) environment.
  • Rate Limit Mitigation: This change was implemented to address rate limit issues with Imagen 4, which has a lower rate limit, preventing potential CI failures or slowdowns.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request disables two Imagen tests from CI to address rate limiting issues. The change is straightforward and uses preprocessor directives. My review includes a suggestion to also disable a third Imagen test that was missed and to refactor the code to improve readability by grouping the disabled tests.

@a-maurice a-maurice merged commit 57ce426 into main Nov 26, 2025
4 checks passed
@a-maurice a-maurice deleted the am-imagen_tests branch November 26, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants