Fix Unity installation error on Linux #552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunmou99
added
the
tests-requested: quick
sunmou99
added
tests-requested: quick
sunmou99
changed the title
sunmou99
added
tests-requested: quick
sunmou99
added
tests-requested: quick
github-actions
bot
added
tests: in-progress
❌ Integration test FAILEDRequested by @firebase-workflow-trigger[bot] on commit f19dc22
|
sunmou99
added
tests-requested: quick
cynthiajoan
reviewed
Nov 29, 2022
| build_desktop: | ||
| name: build-linux-unity${{inputs.unity_version}}-CPP${{ inputs.firebase_cpp_sdk_version }} | ||
| runs-on: ubuntu-20.04 | ||
| runs-on: ubuntu-latest |
Contributor
There was a problem hiding this comment.
Is this change intentional? Remember we need to ping to ubuntu 20
Contributor
Author
There was a problem hiding this comment.
Yes.
I believe github will remove ubuntu 20 runner in the future. Then, we still need to solve the issue.
This PR is to fix the installation issue on newer ubuntu runners, so that we don't have to ping to ubuntu 20.
Contributor
There was a problem hiding this comment.
Unity does not support Ubuntu 22.04. This should be reverted until the next Unity Hub release that does support it.
Contributor
There was a problem hiding this comment.
See forum post for details https://forum.unity.com/threads/running-unity-on-ubuntu-22-04.1284083/
I've already tried the workaround in my installation scripts but cannot get around the fuse error
Contributor
Author
There was a problem hiding this comment.
Thanks for the info.
Yeah, I also tried the workaround and it didn't work.
But, we are building SDK here and only installing (not launching) Editor.
So, it worked in my CI:
I1129 21:42:55.199143 140596922395520 unity_installer.py:343] run_with_retry: xvfb-run unityhub --headless install --version 2020.3.40f1 --changeset ba48d4efcef1 (attempt 1 of 3)
I1129 21:46:01.864848 140596922395520 unity_installer.py:346] cmd stdout: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
Error: Unknown or unsupported transport “disabled” for address “disabled:”
This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
...
Progress:
[Unity 2020.3.40f1] downloading 98.77%
Progress:
[Unity 2020.3.40f1] downloading 100.00%
Progress:
[Unity 2020.3.40f1] finished downloading.
Progress:
[Unity 2020.3.40f1] finished downloading.
Progress:
[Unity 2020.3.40f1] queued for install.
Progress:
[Unity 2020.3.40f1] queued for install.
Progress:
[Unity 2020.3.40f1] validating installation...
Progress:
[Unity 2020.3.40f1] validating installation...
Progress:
[Unity 2020.3.40f1] installing...
Progress:
[Unity 2020.3.40f1] installed successfully.
All Tasks Completed Successfully.
Progress:
[Unity 2020.3.40f1] installed successfully.
All Tasks Completed Successfully.
Contributor
There was a problem hiding this comment.
You guys don't do and validation and testing in editor?
Contributor
Author
There was a problem hiding this comment.
We do. But not on Ubuntu runners.
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
cynthiajoan
approved these changes
Dec 14, 2022
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
mrober
pushed a commit
that referenced
this pull request
Jan 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current unity installation process on newer ubuntu runners has an issue: https://github.com/firebase/firebase-unity-sdk/actions/runs/3567833638/jobs/5996016337#step:8:74
Updated Unity Installation process on ubuntu runners based on: https://docs.unity3d.com/hub/manual/InstallHub.html#install-hub-linux
Testing
https://github.com/firebase/firebase-unity-sdk/actions/runs/3578235575/jobs/6018161702
Also see the comment below
Type of Change
Place an
xthe applicable box: