Skip to content

Conversation

@DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Jan 5, 2023

Description

Provide details of the change, and generalize the change in the PR title above.

Two dynamic links tests are constantly failing on mobile platforms:

  • TestCreateShortLinkAsync
  • TestCreateUnguessableShortLinkAsync

Disable these tests so we can get CI to green.
Track the need to fix these tests in b/264533368

Note: these tests are already disabled on Desktop platforms as they're unsupported in that environment.


Testing

Describe how you've tested these changes.

Integration Test CI


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@DellaBitta DellaBitta marked this pull request as ready for review January 5, 2023 23:09
@DellaBitta DellaBitta merged commit 952a3b7 into main Jan 5, 2023
@DellaBitta DellaBitta deleted the build_fix/disable_dynamic_links branch January 5, 2023 23:15
@firebase firebase locked and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants