Skip to content

Conversation

@DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Jan 12, 2023

Description

Provide details of the change, and generalize the change in the PR title above.

Fixes to the Storage, Database, Crashlytics and Messaging tests. These testapps has variable behavior based on the target device, and use UNITY_IOS or UNITY_ANDROID preprocessors to toggle off certain tests. These preprocessor definitions are automatically defined for us by Unity when building for the applicable platforms.

This change adds UNITY_TVOS where appropriate and makes it use the same tests & code as UNITY_IOS.

Additionally the Storage tests that download to disk have been disabled since tvOS does not have a dependable file system to test against.

Flaky tests that failed in CI were Installations, Messaging, and Functions. When verifying these tests locally on tvOS simulators, both Installations and Functions pass. Messaging has the same error result as our tests iOS on simulators, which I also verifed locally.


Testing

Describe how you've tested these changes.

Integration Test CI


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@DellaBitta DellaBitta marked this pull request as ready for review January 13, 2023 16:06
@DellaBitta DellaBitta merged commit 6f540ea into main Jan 13, 2023
@DellaBitta DellaBitta deleted the feature/itest_use_tvos_build branch January 13, 2023 18:24
@firebase firebase locked and limited conversation to collaborators Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants