Fix tvOS iTests - Use UNITY_TVOS and disable Storage filesystem tests #597
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes to the Storage, Database, Crashlytics and Messaging tests. These testapps has variable behavior based on the target device, and use
UNITY_IOSorUNITY_ANDROIDpreprocessors to toggle off certain tests. These preprocessor definitions are automatically defined for us by Unity when building for the applicable platforms.This change adds
UNITY_TVOSwhere appropriate and makes it use the same tests & code asUNITY_IOS.Additionally the Storage tests that download to disk have been disabled since tvOS does not have a dependable file system to test against.
Flaky tests that failed in CI were Installations, Messaging, and Functions. When verifying these tests locally on tvOS simulators, both Installations and Functions pass. Messaging has the same error result as our tests iOS on simulators, which I also verifed locally.
Testing
Integration Test CI
Type of Change
Place an
xthe applicable box: