Skip to content

Conversation

@a-maurice
Copy link
Collaborator

@a-maurice a-maurice commented Jun 28, 2023

Description

Provide details of the change, and generalize the change in the PR title above.

Add logic to check which versions of iOS/tvOS are available, and fallback to the latest if the requested one isn't available. Also change to using xcodes to install iOS simulators, since xcode-install has been deprecated in favor of it.


Testing

Describe how you've tested these changes.

Running locally, and https://github.com/firebase/firebase-unity-sdk/actions/runs/5395850671


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@a-maurice a-maurice requested a review from sunmou99 June 28, 2023 01:07
Copy link
Contributor

@sunmou99 sunmou99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-maurice a-maurice merged commit 56d7682 into main Jun 28, 2023
@a-maurice a-maurice deleted the am-ios_installs branch June 28, 2023 17:33
@firebase firebase locked and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants