Skip to content

fix(react,angular): Prevent double form validation errors #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2025
Merged

fix(react,angular): Prevent double form validation errors #1248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f02ae1
chore: Fix example internal links
Ehesp Nov 4, 2025
729309e
fix(react,angular): Prevent double form validation errors
Ehesp Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/react/src/routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export const routes = [
{
name: "Forgot Password Screen",
description: "A screen allowing a user to reset their password",
path: "/screens/forgot-password-screen",
path: "/screens/forgot-password-auth-screen",
component: ForgotPasswordAuthScreenPage,
},
{
Expand Down
2 changes: 1 addition & 1 deletion examples/react/src/screens/sign-in-auth-screen-w-handlers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export default function SignInAuthScreenWithHandlersPage() {
return (
<SignInAuthScreen
onForgotPasswordClick={() => {
navigate("/screen/forgot-password-auth-screen");
navigate("/screens/forgot-password-auth-screen");
}}
onSignUpClick={() => {
navigate("/screens/sign-up-auth-screen");
Expand Down
1 change: 0 additions & 1 deletion packages/angular/src/lib/auth/forms/email-link-auth-form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ export class EmailLinkAuthFormComponent {
this.form.update({
validators: {
onBlur: this.formSchema(),
onSubmit: this.formSchema(),
onSubmitAsync: async ({ value }) => {
try {
await sendSignInLinkToEmail(this.ui(), value.email);
Expand Down
1 change: 0 additions & 1 deletion packages/angular/src/lib/auth/forms/forgot-password-auth-form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ export class ForgotPasswordAuthFormComponent {
this.form.update({
validators: {
onBlur: this.formSchema(),
onSubmit: this.formSchema(),
onSubmitAsync: async ({ value }) => {
try {
await sendPasswordResetEmail(this.ui(), value.email);
Expand Down
1 change: 0 additions & 1 deletion packages/angular/src/lib/auth/forms/mfa/totp-multi-factor-assertion-form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ export class TotpMultiFactorAssertionFormComponent {
this.form.update({
validators: {
onBlur: this.formSchema(),
onSubmit: this.formSchema(),
onSubmitAsync: async ({ value }) => {
try {
const assertion = TotpMultiFactorGenerator.assertionForSignIn(this.hint().uid, value.verificationCode);
Expand Down
2 changes: 0 additions & 2 deletions packages/angular/src/lib/auth/forms/phone-auth-form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ export class PhoneNumberFormComponent {
this.form.update({
validators: {
onBlur: this.formSchema(),
onSubmit: this.formSchema(),
onSubmitAsync: async ({ value }) => {
const selectedCountry = countryData.find((c) => c.code === this.country());
const formattedNumber = formatPhoneNumber(value.phoneNumber, selectedCountry!);
Expand Down Expand Up @@ -207,7 +206,6 @@ export class VerificationFormComponent {
this.form.update({
validators: {
onBlur: this.formSchema(),
onSubmit: this.formSchema(),
onSubmitAsync: async ({ value }) => {
try {
const credential = await confirmPhoneNumber(this.ui(), this.verificationId(), value.verificationCode);
Expand Down
2 changes: 0 additions & 2 deletions packages/angular/src/lib/auth/forms/sign-in-auth-form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,7 @@ export class SignInAuthFormComponent {
effect(() => {
this.form.update({
validators: {
onChange: this.formSchema(),
onBlur: this.formSchema(),
onSubmit: this.formSchema(),
onSubmitAsync: async ({ value }) => {
try {
const credential = await signInWithEmailAndPassword(this.ui(), value.email, value.password);
Expand Down
1 change: 0 additions & 1 deletion packages/angular/src/lib/auth/forms/sign-up-auth-form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ export class SignUpAuthFormComponent {
this.form.update({
validators: {
onBlur: this.formSchema(),
onSubmit: this.formSchema(),
onSubmitAsync: async ({ value }) => {
try {
const credential = await createUserWithEmailAndPassword(
Expand Down
1 change: 0 additions & 1 deletion packages/react/src/auth/forms/email-link-auth-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ export function useEmailLinkAuthForm(onSuccess?: EmailLinkAuthFormProps["onEmail
},
validators: {
onBlur: schema,
onSubmit: schema,
onSubmitAsync: async ({ value }) => {
try {
await action(value);
Expand Down
1 change: 0 additions & 1 deletion packages/react/src/auth/forms/forgot-password-auth-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ export function useForgotPasswordAuthForm(onSuccess?: ForgotPasswordAuthFormProp
},
validators: {
onBlur: schema,
onSubmit: schema,
onSubmitAsync: async ({ value }) => {
try {
await action(value);
Expand Down
2 changes: 0 additions & 2 deletions packages/react/src/auth/forms/mfa/sms-multi-factor-assertion-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ export function useSmsMultiFactorAssertionPhoneForm({
},
validators: {
onBlur: schema,
onSubmit: schema,
onSubmitAsync: async () => {
try {
const verificationId = await action({ hint, recaptchaVerifier });
Expand Down Expand Up @@ -144,7 +143,6 @@ export function useSmsMultiFactorAssertionVerifyForm({
verificationCode: "",
},
validators: {
onSubmit: schema,
onBlur: schema,
onSubmitAsync: async ({ value }) => {
try {
Expand Down
2 changes: 0 additions & 2 deletions packages/react/src/auth/forms/mfa/sms-multi-factor-enrollment-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ export function useSmsMultiFactorEnrollmentPhoneNumberForm({
},
validators: {
onBlur: schema,
onSubmit: schema,
onSubmitAsync: async ({ value }) => {
try {
const formatted = formatPhoneNumber ? formatPhoneNumber(value.phoneNumber) : value.phoneNumber;
Expand Down Expand Up @@ -156,7 +155,6 @@ export function useMultiFactorEnrollmentVerifyPhoneNumberForm({
verificationCode: "",
},
validators: {
onSubmit: schema,
onBlur: schema,
onSubmitAsync: async ({ value }) => {
try {
Expand Down
1 change: 0 additions & 1 deletion packages/react/src/auth/forms/mfa/totp-multi-factor-assertion-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ export function useTotpMultiFactorAssertionForm({ hint, onSuccess }: UseTotpMult
verificationCode: "",
},
validators: {
onSubmit: schema,
onBlur: schema,
onSubmitAsync: async ({ value }) => {
try {
Expand Down
2 changes: 0 additions & 2 deletions packages/react/src/auth/forms/mfa/totp-multi-factor-enrollment-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ export function useTotpMultiFactorSecretGenerationForm({ onSuccess }: UseTotpMul
},
validators: {
onBlur: schema,
onSubmit: schema,
onSubmitAsync: async ({ value }) => {
try {
const secret = await action();
Expand Down Expand Up @@ -117,7 +116,6 @@ export function useMultiFactorEnrollmentVerifyTotpForm({
verificationCode: "",
},
validators: {
onSubmit: schema,
onBlur: schema,
onSubmitAsync: async ({ value }) => {
try {
Expand Down
2 changes: 0 additions & 2 deletions packages/react/src/auth/forms/phone-auth-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ export function usePhoneNumberForm({ recaptchaVerifier, onSuccess, formatPhoneNu
},
validators: {
onBlur: schema,
onSubmit: schema,
onSubmitAsync: async ({ value }) => {
try {
const formatted = formatPhoneNumber ? formatPhoneNumber(value.phoneNumber) : value.phoneNumber;
Expand Down Expand Up @@ -146,7 +145,6 @@ export function useVerifyPhoneNumberForm({ verificationId, onSuccess }: UseVerif
verificationCode: "",
},
validators: {
onSubmit: schema,
onBlur: schema,
onSubmitAsync: async ({ value }) => {
try {
Expand Down
1 change: 0 additions & 1 deletion packages/react/src/auth/forms/sign-in-auth-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ export function useSignInAuthForm(onSuccess?: SignInAuthFormProps["onSignIn"]) {
},
validators: {
onBlur: schema,
onSubmit: schema,
onSubmitAsync: async ({ value }) => {
try {
const credential = await action(value);
Expand Down
1 change: 0 additions & 1 deletion packages/react/src/auth/forms/sign-up-auth-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ export function useSignUpAuthForm(onSuccess?: SignUpAuthFormProps["onSignUp"]) {
} as z.infer<typeof schema>,
validators: {
onBlur: schema,
onSubmit: schema,
onSubmitAsync: async ({ value }) => {
try {
const credential = await action(value);
Expand Down