-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat(web): add registerVersion support for packages
#17780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ion` across Firebase web packages
…initialization callback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good! Double check with @cynthiajoan about the naming of the library and a couple of minor adjustments from my perspective, and it LGTM.
packages/cloud_firestore/cloud_firestore_web/lib/src/cloud_firestore_version.dart
Outdated
Show resolved
Hide resolved
packages/firebase_core/firebase_core_web/lib/src/firebase_core_web.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change. The package name should be in the format of flutter-fire-xxxx
You can check the user-agent.gradle file for each package to take the reference
/packages/cloud_firestore/cloud_firestore/android/user-agent.gradle
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for registerVersion for web packages, which helps in tracking package versions for analytics. The implementation involves a new script to auto-generate version files and updates to firebase_core_web to handle version registration. The changes are applied consistently across all relevant web packages. My review includes a couple of suggestions to improve the script's cross-platform compatibility and to fix the pre-commit hook to ensure the generated files are correctly staged.
…kage version files
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?