Skip to content

Conversation

@SelaseKay
Copy link
Contributor

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good! Double check with @cynthiajoan about the naming of the library and a couple of minor adjustments from my perspective, and it LGTM.

@SelaseKay SelaseKay marked this pull request as ready for review October 10, 2025 14:49
@cynthiajoan cynthiajoan self-requested a review October 16, 2025 17:51
Copy link
Collaborator

@cynthiajoan cynthiajoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. The package name should be in the format of flutter-fire-xxxx

You can check the user-agent.gradle file for each package to take the reference
/packages/cloud_firestore/cloud_firestore/android/user-agent.gradle

@cynthiajoan
Copy link
Collaborator

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for registerVersion for web packages, which helps in tracking package versions for analytics. The implementation involves a new script to auto-generate version files and updates to firebase_core_web to handle version registration. The changes are applied consistently across all relevant web packages. My review includes a couple of suggestions to improve the script's cross-platform compatibility and to fix the pre-commit hook to ensure the generated files are correctly staged.

@SelaseKay SelaseKay merged commit 3c8c83d into main Oct 22, 2025
28 of 30 checks passed
@SelaseKay SelaseKay deleted the feat/registerVersion-web-support branch October 22, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants