Skip to content

fix(core, web): More explicit interop types #17809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 24, 2025
+4 −17
Merged

fix(core, web): More explicit interop types #17809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0741a9
fix(core, web): More explicit interop types
MichaelVerdon Oct 23, 2025
8f27c1f
fix: format
MichaelVerdon Oct 23, 2025
695163c
chore: finish migration
MichaelVerdon Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions packages/firebase_core/firebase_core_web/lib/src/interop/app_interop.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,7 @@ import 'dart:js_interop';

import 'core_interop.dart';

@JS('FirebaseApp')
@staticInterop
abstract class AppJsImpl {}

extension AppJsImplExtension on AppJsImpl {
extension type AppJsImpl._(JSObject _) implements JSObject {
external JSString get name;
external FirebaseOptions get options;
}
15 changes: 3 additions & 12 deletions packages/firebase_core/firebase_core_web/lib/src/interop/core_interop.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ import 'dart:js_interop';
import 'package:firebase_core_web/firebase_core_web_interop.dart';

@JS()
// List<AppJsImpl>
external JSArray getApps();
external JSArray<AppJsImpl> getApps();

/// The current SDK version.
///
Expand Down Expand Up @@ -42,12 +41,7 @@ external void registerVersion(
/// In addition to a message string, it contains a string-valued code.
///
/// See: <https://firebase.google.com/docs/reference/js/firebase.FirebaseError>.
@JS('FirebaseError')
@anonymous
@staticInterop
abstract class FirebaseErrorJSImpl {}

extension FirebaseErrorExtension on FirebaseErrorJSImpl {
extension type FirebaseErrorJsImpl._(JSObject _) implements JSObject {
external JSString get code;
external JSString get message;
external JSString get name;
Expand All @@ -58,10 +52,7 @@ extension FirebaseErrorExtension on FirebaseErrorJSImpl {
}

/// A structure for options provided to Firebase.
@JS()
@anonymous
@staticInterop
class FirebaseOptions {
extension type FirebaseOptions._(JSObject _) implements JSObject {
external factory FirebaseOptions({
JSString? apiKey,
JSString? authDomain,
Expand Down
Loading