Skip to content

Conversation

creativecreatorormaybenot
Copy link
Contributor

@creativecreatorormaybenot creativecreatorormaybenot commented Jul 10, 2020

Description

This expands on #2929: I think the collection reference was missing the == override and it also seems to make more sense to check if the pointers are equal rather than the paths, which are derived from the pointers. Essentially, this makes changing the Pointer behavior more easily.

Additionally, I added some tests that ensure that no regression occurs. The changelog entries that @IchordeDionysos added already reflect exactly what these changes do, so there is no need for another entry.

Related Issues

#2929

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, this is not a breaking change.

@creativecreatorormaybenot
Copy link
Contributor Author

@Salakar Is the doc4 failing test caused by me? I do not exactly understand how it would cause that test to fail 😶

@Salakar
Copy link
Member

Salakar commented Jul 13, 2020

@Salakar Is the doc4 failing test caused by me? I do not exactly understand how it would cause that test to fail 😶

Don't think so, we're aware of a potential race condition on the web tests that we're looking into.

@creativecreatorormaybenot
Copy link
Contributor Author

@Ehesp done.

@kroikie kroikie assigned Ehesp and Salakar and unassigned Ehesp Jul 14, 2020
Copy link
Member

@Ehesp Ehesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good thanks, just a small change and should be good.

@Salakar Salakar merged commit df65272 into firebase:master Jul 15, 2020
@creativecreatorormaybenot creativecreatorormaybenot deleted the document-reference-equality branch July 15, 2020 12:24
@firebase firebase locked and limited conversation to collaborators Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants