-
Notifications
You must be signed in to change notification settings - Fork 4.1k
fix(firestore): collection and document equality checking #2931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(firestore): collection and document equality checking #2931
Conversation
@Salakar Is the |
Don't think so, we're aware of a potential race condition on the web tests that we're looking into. |
...e_platform_interface/lib/src/platform_interface/platform_interface_collection_reference.dart
Outdated
Show resolved
Hide resolved
...e_platform_interface/lib/src/platform_interface/platform_interface_collection_reference.dart
Outdated
Show resolved
Hide resolved
@Ehesp done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good thanks, just a small change and should be good.
Description
This expands on #2929: I think the collection reference was missing the
==
override and it also seems to make more sense to check if the pointers are equal rather than the paths, which are derived from the pointers. Essentially, this makes changing thePointer
behavior more easily.Additionally, I added some tests that ensure that no regression occurs. The changelog entries that @IchordeDionysos added already reflect exactly what these changes do, so there is no need for another entry.
Related Issues
#2929
Checklist
///
).flutter analyze
) does not report any problems on my PR.Breaking Change