Skip to content

Conversation

@creativecreatorormaybenot
Copy link
Contributor

@creativecreatorormaybenot creativecreatorormaybenot commented Jul 15, 2020

Description

This fixes something that I introduced in #2931. It seems like there was a very weird Git diff bug there because I had it exactly like this in my local file 😶 (the diff on GitHub showed the opposite, i.e. [UNPUBLISHED] was still there and I added the version 🤷🏽‍♀️

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@creativecreatorormaybenot creativecreatorormaybenot changed the title fix(cloud_firestore) CHANGELOG fix(cloud_firestore): CHANGELOG Jul 15, 2020
@creativecreatorormaybenot
Copy link
Contributor Author

You can even still see the GitHub diff here. It seems like it ran on an outdated head.

@Salakar Salakar changed the title fix(cloud_firestore): CHANGELOG docs(cloud_firestore): update changelog Jul 15, 2020
@Salakar Salakar merged commit 21458f6 into firebase:master Jul 15, 2020
@Salakar
Copy link
Member

Salakar commented Jul 15, 2020

Thank you :)

@firebase firebase locked and limited conversation to collaborators Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants