Skip to content

Conversation

russellwheatley
Copy link
Member

Description

Crashlytics still requires the Firebase APP_ID in native service file according to issue reports.
There is also another problem running from runZonedGuarded as the initialization is occurring too late and causes the app to throw an exception.

So Crashlytics still needs native initialization for now.

Related Issues

none.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley added the blocked: do-not-merge PR blocked externally label Feb 24, 2022
@Salakar
Copy link
Member

Salakar commented Feb 24, 2022

As discussed internally lets park this in favour of #8157 and invertase/flutterfire_cli#43 - may not be required after these + Android equivalent

@Salakar Salakar closed this Mar 31, 2022
@firebase firebase locked and limited conversation to collaborators May 1, 2022
@Lyokone Lyokone deleted the @russell/fix-crash-example branch November 29, 2022 08:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked: do-not-merge PR blocked externally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants