feat(crashlytics): add automatic Crashlytics symbol uploads for iOS & macOS apps #8157
+179
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elenadoty
changed the title
10 tasks
Salakar
reviewed
Feb 24, 2022
packages/firebase_crashlytics/firebase_crashlytics/ios/crashlytics_add_upload_symbols
Outdated
Show resolved
Hide resolved
elenadoty
force-pushed
the
podspec-injection
branch
from
def90cb to
f6c6149
Compare
Salakar
approved these changes
Mar 31, 2022
|
Thanks again for this 🎉 I will merge this now for todays release. The e2e job failures are relating to an issue with the Firebase Storage emulator - we're working on this excluding these (separate PR) for now until emulator issue can be resolved. iOS and macOS are building fine with script running successfully. |
Salakar
changed the title
|
Appreciate your work but this is a breaking change. It forces projects to use flutterfire_cli to generate firebase_app_id_file.json file. I do not use flutterfire_cli. I prefer to download GoogleService-Info.plist like I did in native. Can we change the implementation to read googleAppId from an environment variable or something does not depend on flutterfire_cli? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a script that automatically adds Crashlytics's upload-symbols tool to the run script of Xcode projects for iOS apps when the Crashlytics plugin is added as a dependency to the project.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?