Skip to content

Exif function example, fix "not defined" errors. #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 20, 2018
Merged

Exif function example, fix "not defined" errors. #378

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
40d2067
Fix exif Firebase exif function example
sefk Apr 20, 2018
f5689f1
Merge branch 'master' of github.com:firebase/functions-samples into e…
sefk Apr 20, 2018
d33e35a
Avoid nested promises in exif function example.
sefk Apr 20, 2018
343df4d
Corrected styling and promise chaining.
nicolasgarnier Apr 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions exif-images/functions/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,22 +43,27 @@ exports.metadata = functions.storage.object().onFinalize((object) => {
return null;
}

let metadata;
// Download file from bucket.
const bucket = gcs.bucket(object.bucket);
return bucket.file(filePath).download({destination: tempLocalFile}).then(() => {
// Get Metadata from image.
return spawn('identify', ['-verbose', tempLocalFile], {capture: ['stdout', 'stderr']});
}).then(() => {
const metadata = imageMagickOutputToObject(result.stdout);
return spawn('identify', ['-verbose', tempLocalFile], {capture: ['stdout', 'stderr']})
}).then((result) => {
// Save metadata to realtime datastore.
return admin.database().ref(makeKeyFirebaseCompatible(filePath)).set(metadata);
metadata = imageMagickOutputToObject(result.stdout);
const safeKey = makeKeyFirebaseCompatible(filePath);
return admin.database().ref(safeKey).set(metadata);
}).then(() => {
return console.log('Wrote to:', filePath, 'data:', metadata);
console.log('Wrote to:', filePath, 'data:', metadata);
return null;
}).then(() => {
// Cleanup temp directory after metadata is extracted
// Remove the file from temp directory
fs.unlinkSync(tempLocalFile);
return console.log('cleanup successful!');
return fs.unlinkSync(tempLocalFile)
}).then(() => {
console.log('cleanup successful!');
return null;
});
});

Expand Down