Skip to content

Clear trace metadata from logs not used by GCP plugin. #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Clear trace metadata from logs not used by GCP plugin. #1118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions js/plugins/google-cloud/src/gcpOpenTelemetry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,15 @@ export class GcpOpenTelemetry {
`projects/${projectId}/traces/${spanContext.traceId}`;
record['logging.googleapis.com/trace_sampled'] ??= isSampled ? '1' : '0';
record['logging.googleapis.com/spanId'] ??= spanContext.spanId;

// Clear out the duplicate trace and span information in the log metadata.
// These will be incorrect for logs written during span export time since
// the logs are written after the span has fully executed. Those logs are
// explicitly tied to the correct span in createCommonLogAttributes in
// utils.ts.
delete record['span_id'];
delete record['trace_id'];
delete record['trace_flags'];
};

async getConfig(): Promise<Partial<NodeSDKConfiguration>> {
Expand Down
Loading