Update deploy and auth documentation to use menuSuggestionFlow #112
Conversation
|
I suggest we split this into 2 PRs. One that ensures that the "deployment" related docs work as intended with |
MaesterChestnut
force-pushed
the
cc/docSampleUpdates
branch
from
32fe119 to
e133523
Compare
MaesterChestnut
force-pushed
the
cc/docSampleUpdates
branch
from
e133523 to
d98a8be
Compare
MichaelDoyle
changed the title
MichaelDoyle
left a comment
MichaelDoyle
left a comment
There was a problem hiding this comment.
Made a few comments.
Please pay particular attention to variable names that need to change along with the flow. I highlighted ones that I spotted, but there are likely more.
docs/deploy-node.md
Outdated
There was a problem hiding this comment.
Should this still take "banana" as input?
docs/deploy-node.md
Outdated
There was a problem hiding this comment.
Should this still take "banana" as input?
docs/auth.md
Outdated
There was a problem hiding this comment.
Should this still take "banana" as input?
There was a problem hiding this comment.
(if we're still going w/ menuSuggestionFlow)
docs/auth.md
Outdated
There was a problem hiding this comment.
I'm a little torn on using menuSuggestionFlow here, since the rest of the doc before and after this point refer to selfSummaryFlow. I'm wondering if we should use the same (i.e. selfSummaryFlow) throughout.
docs/cloud-run.md
Outdated
There was a problem hiding this comment.
There are still some references below that need to be updated.
L129-131 - subject matter doesn't work as well w/ menuSuggestionFlow
L162-166 curls jokeFlow w/ banana as input.
docs/auth.md
Outdated
There was a problem hiding this comment.
Reference to (joke) a few more lines below as an input param under authPolicy.
MaesterChestnut
force-pushed
the
cc/docSampleUpdates
branch
from
d98a8be to
9cc4590
Compare
4 participants
No description provided.