[JS] Adds custom format implementations. #708 part 1 #1125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbleigh
changed the title
mbleigh
changed the title
|
Thank you, @mbleigh! I understand now. It was a good exercise to start getting familiar with the codebase, as it allowed me to explore the core, AI, and other modules. I'll look for another task to work on. |
apascal07
reviewed
Oct 28, 2024
apascal07
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR in a series that will work toward #708, which has now been updated with a work plan for the various pieces that need to go into it..
@galihlprakoso FYI -- this feature is pretty big and consequential and has been on my list to work through for a long time. I appreciate the contribution (and would love if you can find more things you want to add!) but I'm going to implement custom formats directly since there's a lot of complex interaction between various parts of the library.
In this PR I've added a new interface for custom formats and implemented several default formats but haven't yet integrated it with
generateor the broader ecosystem. It is well-tested though.