Refactor formatter interface into stateless function - #708 part 2 #1131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to refactor this to handle the fact that formatters serve two purposes:
There is now essentially a "static" and "dynamic" aspect to formatters. I'm going with
contentTypeas a model-only signal for the requested return type...by separating it fromformatwe can have formats that build on top of JSON while still relying on it.I'm trying to chop this up into reasonably reviewable chunks since otherwise this project would turn into a 10K line PR. Apologies if the pacing ends up being a bit strange.
Checklist (if applicable):