-
Notifications
You must be signed in to change notification settings - Fork 565
Add endpoint for the Dev UI to subscribe to runtime updates #1154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonybaroneee
approved these changes
Oct 31, 2024
apascal07
reviewed
Oct 31, 2024
0e35b8e to
3e54fbd
Compare
Member
Author
|
@apascal07 @tonybaroneee made some more tweaks based on feedback and my own testing. PTAL. |
07e5d47 to
710f23d
Compare
tonybaroneee
approved these changes
Nov 3, 2024
Member
Author
|
No worries. Will do. It’s funny that’s my go to as well. Working with VS
Code when I first started with TS all the MS enums are CamelCased. So I
thought that might be the TS norm. 🤷🏻♂️
…On Sun, Nov 3, 2024 at 8:21 AM Anthony Barone ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In genkit-tools/common/src/manager/types.ts
<#1154 (comment)>:
> @@ -26,3 +26,19 @@ export class GenkitToolsError extends Error {
// Streaming callback function.
export type StreamingCallback<T> = (chunk: T) => void;
+
+export interface RuntimeInfo {
+ /** Runtime ID (either user-set or `pid`). */
+ id: string;
+ /** Process ID of the runtime. */
+ pid: number;
+ /** URL of the reflection server. */
+ reflectionServerUrl: string;
+ /** Timestamp when the runtime was started. */
+ timestamp: string;
+}
+
+export enum RuntimeEvent {
+ Add = 'add',
nit: TS enum keys are conventionally all uppercase (e.g. ADD = 'add'), I
would update these.
—
Reply to this email directly, view it on GitHub
<#1154 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVZ2UXWRBK4KXOGDIINQI3Z6YINBAVCNFSM6AAAAABQ67U222VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMJRHA2TIMZQHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Collaborator
|
Haha yeah it's like a C#-ism, probably explains that. |
710f23d to
de3ce69
Compare
Member
Author
|
I merged this in to unblock dev ui work, but I am more than happy to follow up on anything if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (if applicable):
cc @tonybaroneee