Skip to content

Re-initializing GCP logger after it experiences a failure. #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Re-initializing GCP logger after it experiences a failure. #1161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions js/plugins/google-cloud/src/gcpLogger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*/

import { LoggingWinston } from '@google-cloud/logging-winston';
import { getCurrentEnv } from 'genkit';
import { logger } from 'genkit/logging';
import { Writable } from 'stream';
import { GcpTelemetryConfig } from './types';
Expand Down Expand Up @@ -56,6 +57,7 @@ export class GcpLogger {
prefix: 'genkit',
logName: 'genkit_log',
credentials: this.config.credentials,
autoRetry: true,
defaultCallback: await this.getErrorHandler(),
})
: new winston.transports.Console()
Expand Down Expand Up @@ -90,6 +92,13 @@ export class GcpLogger {
} else if (err) {
defaultLogger.error(`Unable to send logs to Google Cloud: ${err}`);
}

if (err) {
// Assume the logger is compromised, and we need a new one
// Reinitialize the genkit logger with a new instance with the same config
logger.init(new GcpLogger(this.config).getLogger(getCurrentEnv()));
defaultLogger.info('Initialized a new GcpLogger.');
}
};
}

Expand Down
Loading