refactor(js/ai): moves tool loop logic into its own file, improves readability of generate/action.ts #1673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ible chunks [WIP]
mbleigh
force-pushed
the
mb/generate-redux
branch
from
96084ac to
21ddaf6
Compare
pavelgj
reviewed
Jan 28, 2025
pavelgj
reviewed
Jan 28, 2025
pavelgj
reviewed
Jan 28, 2025
pavelgj
reviewed
Jan 28, 2025
pavelgj
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't quite ready (still two tests failing that I'm looking into) but this is a beefy refactor mainly of
ai/src/generate/action.tsinto something more manageable. I was finding it almost impossible to follow all the logic being applied so I tried to break it down into smaller pieces and rename things a bit to make it more understandable.