[Go] added action type and subtype span metadata to actions #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelgj
changed the title
jba
approved these changes
May 24, 2024
Contributor
|
Thanks. |
jba
added a commit
that referenced
this pull request
May 24, 2024
This PR greatly simplifies the genkit package, limiting it to the symbols that Genkit app developers, as exemplified by the programs in the "samples" directory, would need. To accomplish this, it moves most of the code to a new package, named core. The core package, rather than the genkit package, is now imported by the ai package and plugins. End-user applications should not normally require it. This overlapped with #229, so unfortunately those (minor) changes are incorporated here as well, in a slightly different form.
jba
added a commit
that referenced
this pull request
May 24, 2024
This PR greatly simplifies the genkit package, limiting it to the symbols that Genkit app developers, as exemplified by the programs in the "samples" directory, would need. To accomplish this, it moves most of the code to a new package, named core. The core package, rather than the genkit package, is now imported by the ai package and plugins. End-user applications should not normally require it. This overlapped with #229, so unfortunately those (minor) changes are incorporated here as well, in a slightly different form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make sure that spans are properly rendered in the Dev UI