Skip to content

fix: passthrough streaming callback on dotprompt render #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2024
Merged

fix: passthrough streaming callback on dotprompt render #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a286fb5
Passthrough streaming callback on dotprompt render
pavelgj May 25, 2024
f18a388
format
pavelgj May 25, 2024
e957690
returnToolRequests
pavelgj May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions js/plugins/dotprompt/src/prompt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,8 @@ export class Dotprompt<Variables = unknown> implements PromptMetadata {
jsonSchema: options.output?.jsonSchema || this.output?.jsonSchema,
},
tools: (options.tools || []).concat(this.tools || []),
streamingCallback: options.streamingCallback,
returnToolRequests: options.returnToolRequests,
};
}

Expand Down
14 changes: 14 additions & 0 deletions js/plugins/dotprompt/tests/prompt_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,20 @@ describe('Prompt', () => {
await invalidSchemaPrompt.render({ input: { foo: 'baz' } });
}, ValidationError);
});

it('should render with overrided fields', async () => {
const prompt = testPrompt(`Hello {{name}}, how are you?`);

const streamingCallback = (c) => console.log(c);

const rendered = await prompt.render({
input: { name: 'Michael' },
streamingCallback,
returnToolRequests: true,
});
assert.strictEqual(rendered.streamingCallback, streamingCallback);
assert.strictEqual(rendered.returnToolRequests, true);
});
});

describe('#generate', () => {
Expand Down