fix(py): Use file-safe timestamp format for runtime file to prevent OSError on Windows #3727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows does not support colon in filename so flow runner failing, fixed it by using hyphen and underscore
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
pavelgj
changed the title
pavelgj
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(logging): Use file-safe timestamp format to prevent OSError on Windows
The default string representation of the Python datetime object (e.g., 2025-10-17T15:34:10.127678) includes the colon (:) character in the time component.
The colon is an illegal character for standard filenames on the Windows filesystem, which resulted in an OSError: [Errno 22] Invalid argument whenever genkit attempted to save trace/log files on that platform.
This commit updates the file naming logic to use a cross-platform safe timestamp format (e.g., YYYY-MM-DD_HH-MM-SS-ffffff) that omits the illegal colon character, ensuring successful file persistence across all major operating @systems