Skip to content

fix(go): allow the use of snake case fields in dotprompt templates #3744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(go): allow the use of snake case fields in dotprompt templates #3744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion go/ai/prompt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ package ai

import (
"context"
"encoding/json"
"errors"
"fmt"
"log/slog"
Expand Down Expand Up @@ -244,7 +245,16 @@ func buildVariables(variables any) (map[string]any, error) {

v := reflect.Indirect(reflect.ValueOf(variables))
if v.Kind() == reflect.Map {
return variables.(map[string]any), nil
// ensure JSON tags are taken in consideration (allowing snake case fields)
jsonData, err := json.Marshal(variables)
if err != nil {
return nil, fmt.Errorf("unable to marshal prompt field values: %w", err)
}
var resultVariables map[string]any
if err := json.Unmarshal(jsonData, &resultVariables); err != nil {
return nil, fmt.Errorf("unable to unmarshal prompt field values: %w", err)
}
return resultVariables, nil
}
if v.Kind() != reflect.Struct {
return nil, errors.New("prompt.buildVariables: fields not a struct or pointer to a struct or a map")
Expand Down
Loading