Skip to content

[Go] name dev trace store dir like js #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2024
Merged

[Go] name dev trace store dir like js #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions go/genkit/tracing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@ package genkit

import (
"context"
"crypto/md5"
"fmt"
"os"
"path/filepath"
"sync"

"go.opentelemetry.io/otel/attribute"
Expand Down Expand Up @@ -70,12 +73,10 @@ func (ts *tracingState) addTraceStoreBatch(tstore TraceStore) (shutdown func(con
}

func newDevTraceStore() (TraceStore, error) {
// TODO(jba): The js code uses a hash of the program name as the directory,
// so the same store is used across runs. That won't work well with the common
// use of `go run`. Should we let the user configure the directory?
// Does it matter?
dir, err := os.MkdirTemp("", "genkit-tracing")
if err != nil {
programName := filepath.Base(os.Args[0])
rootHash := fmt.Sprintf("%02x", md5.Sum([]byte(programName)))
dir := filepath.Join(os.TempDir(), ".genkit", rootHash, "traces")
if err := os.MkdirAll(dir, 0o755); err != nil {
return nil, err
}
// Don't remove the temp directory, for post-mortem debugging.
Expand Down