[Go] improve core action API #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randall77
approved these changes
Jul 2, 2024
Define a single, general newAction function. Define a single fully general method for defining an action in a registry. All other Define functions call it. Export it so the genkit package can use it to define flows. It's unfortunate that we have to export it, but code outside the module can't call it anyway because it takes a registry, which has an internal type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define a single, general newAction function.
Define a single fully general method for defining an action
in a registry. All other Define functions call it.
Export it so the genkit package can use it to define flows.
It's unfortunate that we have to export it, but code outside the
module can't call it anyway because it takes a registry, which
has an internal type.