[Go] add support for GCP client options #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jba
changed the title
apascal07
approved these changes
Jul 10, 2024
Allow users to pass client options to the GCP clients for the googleai and vertexai plugins. To allow this and also to enable additional config in the future without introducing breaking changes, add a Config struct to each plugin, and have Init take it as an argument. Also, slightly rewrite the samples to avoid redundant code for looking up environment variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to pass client options to the GCP clients for the
googleai and vertexai plugins.
To allow this and also to enable additional config in the future
without introducing breaking changes, add a Config struct to
each plugin, and have Init take it as an argument.
Also, slightly rewrite the samples to avoid redundant code for
looking up environment variables.