[Go] align Embedder API with JS #537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- An EmbedRequest takes a slice of Documents instead of a single Document. - An EmbedResponse contains embeddings for each document. The []float32 containing the embedding is inside a struct, to accommodate future additions (and to match the JS). - The googleai embedder works on multiple documents sequentially. It should be changed to use the BatchEmbed RPC. - The vertexai embedder always handled multiple "instances". Now an instance is the concatenated text parts of a document; before it was one text part of the sole document. (This is the only behavioral change.) There is one unrelated change: the prompt of a generation test was changed because the previous prompt is now blocked for the "recitation" reason.
randall77
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An EmbedRequest takes a slice of Documents instead of a single Document.
An EmbedResponse contains embeddings for each document. The []float32
containing the embedding is inside a struct, to accommodate future
additions (and to match the JS).
The googleai embedder works on multiple documents sequentially.
It should be changed to use the BatchEmbed RPC.
The vertexai embedder always handled multiple "instances". Now an
instance is the concatenated text parts of a document; before it
was one text part of the sole document. (This is the only behavioral
change.)
There is one unrelated change: the prompt of a generation test
was changed because the previous prompt is now blocked for the
"recitation" reason.