Skip to content

[Go] plugins/googlai: use batch embed RPC #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2024
Merged

[Go] plugins/googlai: use batch embed RPC #539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions go/plugins/googleai/googleai.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,19 +163,23 @@ func DefineEmbedder(name string) *ai.Embedder {
// requires state.mu
func defineEmbedder(name string) *ai.Embedder {
return ai.DefineEmbedder(provider, name, func(ctx context.Context, input *ai.EmbedRequest) (*ai.EmbedResponse, error) {
// TODO: use the batch embedding API.
em := state.client.EmbeddingModel(name)
var res ai.EmbedResponse
// TODO: set em.TaskType from EmbedRequest.Options?
batch := em.NewBatch()
for _, doc := range input.Documents {
parts, err := convertParts(doc.Content)
if err != nil {
return nil, err
}
eres, err := em.EmbedContent(ctx, parts...)
if err != nil {
return nil, err
}
res.Embeddings = append(res.Embeddings, &ai.DocumentEmbedding{Embedding: eres.Embedding.Values})
batch.AddContent(parts...)
}
bres, err := em.BatchEmbedContents(ctx, batch)
if err != nil {
return nil, err
}
var res ai.EmbedResponse
for _, emb := range bres.Embeddings {
res.Embeddings = append(res.Embeddings, &ai.DocumentEmbedding{Embedding: emb.Values})
}
return &res, nil
})
Expand Down