Skip to content

Conversation

@ssbushi
Copy link
Contributor

@ssbushi ssbushi commented Jul 4, 2024

Add snippet for pgvector retriever in Golang

  • Tested (manually)
  • Docs updated

@ssbushi ssbushi requested review from pavelgj and peterfriese July 4, 2024 19:31
@ssbushi ssbushi changed the title Add snippet for pgvector retriever in Golang [Go] Add snippet for pgvector retriever in Golang Jul 4, 2024
@pavelgj pavelgj requested a review from kevinthecheung July 9, 2024 01:00
@jba
Copy link
Contributor

jba commented Jul 11, 2024

Looks like something went wrong here. I had a PR for this, #375, but I messed up and it got merged into the wrong branch, not main.

I recommend doing this as in that PR. Then you have a piece of code that compiles. This will inevitably become stale.

@jba
Copy link
Contributor

jba commented Jul 11, 2024

I re-sent #375 as #583.

I think whose code we end up using is less important than checking in actual code. You can use the weave tool to insert parts of the code into the markdown doc.

@ssbushi
Copy link
Contributor Author

ssbushi commented Jul 11, 2024

I don't care whose code we use. Your snippet looks cleaner too!

I will branch off your PR and update the docs file using weave.

@ssbushi ssbushi closed this Jul 11, 2024
@ssbushi ssbushi deleted the sb/pgvectorGo branch November 28, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants