[Go] e2e test for reflection API #551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelgj
reviewed
Jul 11, 2024
Write a Go test that uses the yaml file for reflection API tests from #549. Currently, the api/actions test fails because the schemas are very different between Go and JS.
Contributor
Author
|
I skipped the failing test, but that is just hiding some major inconsistencies the JSON schemas for models. There are also other issues that more tests like this would find, for example #541. |
ianlancetaylor
approved these changes
Jul 11, 2024
apascal07
reviewed
Jul 11, 2024
pavelgj
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write a Go test that uses the yaml file for reflection API tests
from #549.
Currently, the api/actions test fails because the schemas
are very different between Go and JS.