Skip to content

Remove superfluous debug log statements #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Remove superfluous debug log statements #581

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions js/core/src/tracing/localFileTraceStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,6 @@ export class LocalFileTraceStore implements TraceStore {
await mutex.waitForUnlock();
const release = await mutex.acquire();
try {
logger.debug(
`acquired lock to write trace ${id} for trace name ${trace.displayName}`
);
const existing = await this.load(id);
if (existing) {
Object.keys(trace.spans).forEach(
Expand All @@ -97,10 +94,6 @@ export class LocalFileTraceStore implements TraceStore {
existing.endTime = trace.endTime;
trace = existing;
}
logger.debug(
`save trace ${id} with name ${trace.displayName} to ` +
path.resolve(this.storeRoot, `${id}`)
);
fs.writeFileSync(
path.resolve(this.storeRoot, `${id}`),
JSON.stringify(trace)
Expand Down