Skip to content

Conversation

@ssbushi
Copy link
Contributor

@ssbushi ssbushi commented Jul 11, 2024

Checklist (if applicable):

  • Docs updated

jba and others added 2 commits July 11, 2024 09:14
A sample demonstrating how to use Postgres's vector extension
to build an indexer and retriever.

Formerly #375.
@ssbushi ssbushi mentioned this pull request Jul 11, 2024
@ssbushi
Copy link
Contributor Author

ssbushi commented Jul 11, 2024

I want to include more than just the code for defining a retriever (eg: the right imports). But using %include consecutively generates multiple code blocks in the markdown file. I opted to keep it simple

@ssbushi ssbushi requested review from jba and kevinthecheung July 11, 2024 14:59
@ssbushi ssbushi marked this pull request as ready for review July 11, 2024 15:05
Copy link
Contributor

@kevinthecheung kevinthecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't render correctly with markdown embedded within the HTML. Could you please put these files in docs-go instead? (Just the go version.) I will combine everything all at once when go graduates out of alpha

@ssbushi
Copy link
Contributor Author

ssbushi commented Jul 11, 2024

@kevinthecheung Moved the go snippets to docs-go. PTAL

@ssbushi ssbushi requested a review from kevinthecheung July 11, 2024 21:52
Copy link
Contributor

@kevinthecheung kevinthecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ssbushi ssbushi merged commit 2a242b1 into main Jul 12, 2024
@ssbushi ssbushi deleted the sb/pgVectorDocs branch July 12, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants