Fix Lint errors #66
Merged
Fix Lint errors #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependencies from the Facebook SDK are now cleanly isolated in a new AndroidManifest.xml under the facebook source set. It will be merged with the main manifest at compile time.
Merged
This reverts commit 89461c8.
friederbluemle
force-pushed
the
fix-lint-errors
branch
from
c5a4b02 to
bafe78c
Compare
|
@friederbluemle thanks for taking this on! Since the Travis build passes I am going to merge them in. Very much appreciated, I was certainly being lazy by ignoring lint errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All projects now build successfully without ignoring Lint errors (which is almost never a good idea without a strong reason).
There were only a couple of Lint errors. I fixed them in two separate commits:
The first one in the
analyticsproject related to a resource style valuecolorAccentbeing used on API < 21. The other error was in theauthproject related to Facebook SDK dependencies being referenced in themainsource set. Since the project's app/build.gradle specifies the dependency asfacebookCompilethey are only available in thefacebookvariant of the project, thus I moved the declarations to a new AndroidManifest.xml file in the respective folder.