-
Couldn't load subscription status.
- Fork 135
database-setup-bug-fixes #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Database setup
Modifying transaction null check.
Touch Listener hitbox correction. Change back to MainMenu if game_uuid doesn't exist. Added game over firebase field in game_uuid. Removeing Game_Uuid on game over. Added game_outcome tracker. Leave button functionality. Added missing images.
Static and PascelCase GameOver fucntion.
… into 05-bug-fixes
alexames
suggested changes
Jun 19, 2020
if curly brackets.
DellaBitta
reviewed
Jun 21, 2020
DellaBitta
reviewed
Jun 21, 2020
DellaBitta
reviewed
Jun 21, 2020
DellaBitta
reviewed
Jun 21, 2020
DellaBitta
reviewed
Jun 21, 2020
DellaBitta
reviewed
Jun 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments. Nothing killer.
enum for game outcomes. constant image file names.
|
Thanks for the changes! |
alexames
approved these changes
Jun 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Touch Listener hitbox correction.
Change back to MainMenu if game_uuid doesn't exist.
Added game over firebase field in game_uuid.
Removeing Game_Uuid on game over.
Added game_outcome tracker.
Leave button functionality.