Rearranging include and using statements #59
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moving common functions into header files. Moving database & auth to MainMenuScene. Adding Auth node with fields and listeners. Set up user record management. Set up user sign-up, login and anonymous login. * auth full review by @DellaBitta * Private Class variables. Bug on disbanded room.
* Moving common functions to util.h and util.cpp. Adding more comments on util functions. * Added missing period. * removing double new line. modifying includes in util.h and util.cpp
* Moving common functions to util.h and util.cpp. Adding more comments on util functions. * Added missing period. * removing double new line. modifying includes in util.h and util.cpp
* refactor file names * reverting cmake unnessecary changes.
* Update for API changes * Change logging from verbose to warning Otherwise test results get lost in the crowd. * Add spaces around equals signs * Integrate Latest @ 314842997 CL: 314842997 * refactor file names * Adding util.cpp and util.h files (firebase#54) * Auth full changes (#8) * Moving common functions into header files. Moving database & auth to MainMenuScene. Adding Auth node with fields and listeners. Set up user record management. Set up user sign-up, login and anonymous login. * auth full review by @DellaBitta * Private Class variables. Bug on disbanded room. * Moving common functions to util.h and util.cpp. Adding more comments on util functions. * Added missing period. * removing double new line. modifying includes in util.h and util.cpp * reverting cmake unnessecary changes. * deleteing util.cpp. * Removing old include header. Co-authored-by: Mark Grimes <kknb1056@gmail.com> Co-authored-by: Morgan Chen <morganchen12@gmail.com> Co-authored-by: Anthony <amaurice@google.com> Co-authored-by: Alex Ames <amablue@google.com>
Duplicate libaray statements replaced with using statement.
…into rearranging-include-and-using-statements
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly. In order to pass this check, please resolve this problem and then comment ℹ️ Googlers: Go here for more info. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.