Skip to content

Update to Xcode 16.2 for ftl tests #1681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

Update to Xcode 16.2 for ftl tests #1681

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/build-for-testing.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ function xcb() {
}

# Run xcodebuild
sudo xcode-select -s /Applications/Xcode_15.3.app/Contents/Developer
sudo xcode-select -s /Applications/Xcode_16.2.app/Contents/Developer
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider using a variable for the Xcode path to improve maintainability. This way, if the Xcode version needs to be updated again, it can be done in one place. Also, it might be useful to check if the specified Xcode version exists before attempting to select it. This could prevent errors if the Xcode version is not installed.

Suggested change
sudo xcode-select -s /Applications/Xcode_16.2.app/Contents/Developer
XCODE_PATH="/Applications/Xcode_16.2.app/Contents/Developer"
if [[ -d "$XCODE_PATH" ]]; then
sudo xcode-select -s "$XCODE_PATH"
else
echo "Xcode version not found at $XCODE_PATH"
exit 1
fi

xcb "${flags[@]}"
echo "$message"

Expand Down