-
Couldn't load subscription status.
- Fork 1.5k
Update vertexai's README.md to mention the right dir name #1687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…list Because there is not such file. Also, changes to them are ignored by git anyways (see [.gitignore](.gitignore#L5)).
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @nguyenhuy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the README.md file in the vertexai directory to correct the location where the GoogleService-Info.plist file should be saved. It removes the mention of the non-existent mock GoogleService-Info.plist file and updates the instructions to save the file in the vertexai directory instead of FirebaseVertexAI/Sample.
Highlights
- README Update: The
README.mdfile has been updated to reflect the correct directory for saving theGoogleService-Info.plistfile. - Directory Correction: The instructions now point to the
vertexaidirectory instead of the incorrectFirebaseVertexAI/Sampledirectory. - Mock File Removal: The mention of the non-existent
mock GoogleService-Info.plistfile has been removed.
Changelog
- vertexai/README.md
- Updated the directory where the
GoogleService-Info.plistfile should be saved fromFirebaseVertexAI/Sampletovertexai. - Removed mention of the non-existent
mock GoogleService-Info.plistfile.
- Updated the directory where the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A file's path, a simple thing,
Yet errors it can often bring.
With care and grace,
We find its place,
And make the sample code sing.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request updates the README.md file to correct the directory name for the GoogleService-Info.plist file and removes a reference to a non-existent mock file. The changes are straightforward and improve the accuracy of the documentation.
Merge Readiness
The changes are straightforward and improve the accuracy of the documentation. I recommend merging this pull request. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging.
|
Thanks! |
Also, don't mention the non-existing mock GoogleService-Info.plist file.