-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore: Rename FIAM target from InAppMessagingExampleSwift to InAppMessagingExample #1796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @ncooke3, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a minor but important housekeeping task by renaming the primary Xcode target for the InAppMessaging example application. The change updates the target name from Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request begins the process of renaming the InAppMessagingExampleSwift target to InAppMessagingExample. However, the current changes are incomplete and introduce a critical runtime issue due to an outdated module name reference in the storyboard. I've left comments detailing this and other inconsistencies. For a complete and safe rename, several other references to InAppMessagingExampleSwift throughout the project, such as the PRODUCT_BUNDLE_IDENTIFIER build setting, also need to be updated.
| dependencies = ( | ||
| ); | ||
| name = InAppMessagingExampleSwift; | ||
| name = InAppMessagingExample; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the target name to InAppMessagingExample also changes the product's module name. The Main.storyboard file, however, still has a hardcoded reference to the old module name, InAppMessagingExampleSwift, for the ViewController's customModule attribute. This will cause a runtime crash when the app tries to load the view controller from the storyboard because the old module will not be found.
To fix this, you need to update inappmessaging/InAppMessagingExampleSwift/Base.lproj/Main.storyboard and change customModule="InAppMessagingExampleSwift" to customModule="InAppMessagingExample".
| ); | ||
| name = InAppMessagingExampleSwift; | ||
| name = InAppMessagingExample; | ||
| productName = InAppMessagingExampleSwift; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the updated target name, the productName property should also be changed from InAppMessagingExampleSwift to InAppMessagingExample. Although this property is likely overridden by the PRODUCT_NAME build setting, keeping the project file internally consistent improves maintainability and avoids potential confusion.
productName = InAppMessagingExample;
No description provided.