-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[Firebase AI] Switch to Xcode 16 project format #1808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @andrewheard, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant infrastructure update for the Firebase AI Logic quickstart application, transitioning it to the latest Xcode 16 project format. The core motivation is to enhance project maintainability and reduce version control issues by adopting Xcode's new buildable folder references. This involves a comprehensive restructuring of the project's file organization, centralizing all application content within a single 'FirebaseAIExample' directory, which, while introducing some initial changes, is expected to streamline future development and collaboration. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively migrates the Firebase AI quickstart app to the new Xcode 16 project format. The changes primarily involve updating the .pbxproj file to use buildable folder references and enabling "Minimize Project References", which will help reduce merge conflicts in the future. The file structure has also been reorganized by moving source files into a unified FirebaseAIExample directory. The changes are well-contained and align with the stated goal. I've reviewed the project file modifications and they appear correct for an Xcode 16 migration. This is a great maintenance update.
|
Verified that it continues to build and run locally with Xcode 16.2 (for macOS 15 compatibility) and Xcode 26.1 (newer than our CI job). |
Updated the Firebase AI Logic quickstart app to the Xcode 16 Project Format and enabled "Minimize Project References". Moved (using
git mvto retain history) the group contents into theFirebaseAIExamplefolder to match a typical Xcode iOS app project structure.Although this introduces some churn now, it should help us with merge conflicts going forward.