-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[FirebaseAI] Multimodal Attachment Preview Fix #1814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FirebaseAI] Multimodal Attachment Preview Fix #1814
Conversation
Summary of ChangesHello @YoungHypo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue where multimodal attachment previews were not rendering correctly. It introduces a more robust and flexible preview mechanism by allowing each Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully fixes the multimodal attachment preview by implementing a custom previewView. Additionally, it updates the supported file extensions and MIME types to align with the Firebase AI documentation. While the UI fix is solid, the updates to file type handling have introduced a few issues. Specifically, support for the common .jpg extension has been dropped, there's an inconsistency in handling .pcm files, and a potentially incorrect mapping for .mpa files. I've provided detailed comments and suggestions to address these points.
firebaseai/FirebaseAIExample/Features/Multimodal/Models/MultimodalAttachment.swift
Show resolved
Hide resolved
firebaseai/FirebaseAIExample/Features/Multimodal/Models/MultimodalAttachment.swift
Show resolved
Hide resolved
firebaseai/FirebaseAIExample/Features/Multimodal/Models/MultimodalAttachment.swift
Show resolved
Hide resolved
firebaseai/FirebaseAIExample/Features/Multimodal/Models/MultimodalAttachment.swift
Show resolved
Hide resolved
firebaseai/FirebaseAIExample/Features/Multimodal/Models/MultimodalAttachment.swift
Show resolved
Hide resolved
peterfriese
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, approved
7daaa08
into
firebase:peterfriese/firebase-ai-quickstart-refresh-main
Problem
Broken preview flow: Current attachment preview card in MultimodalScreen did not show the custom card UI.

Fix
implemented extension View for MultimodalAttachment so each attachment supplies its own card (AttachmentPreview). This aligns with ConversationKit’s expectations. peterfriese/ConversationKit#20
MIME conformance: I synced supportedFileExtensions and getMimeType with the official Firebase AI multimodal doc (image/video/audio/doc types now match the published list exactly). https://firebase.google.com/docs/ai-logic/input-file-requirements?api=dev