feat(FIR-10892): Internal args for engine #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepansergeevitch
approved these changes
Feb 10, 2022
| specification=EngineRevisionSpecification( | ||
| db_compute_instances_type_key=instance_type_key, | ||
| db_compute_instances_count=scale, | ||
| db_compute_instances_use_spot=False, |
There was a problem hiding this comment.
Do we wan't to have some defaults for db_compute_instances_use_spot, db_version, proxy_instances_count and proxy_version?
There was a problem hiding this comment.
We already have those defaults in EngineRevisionSpecification,
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing special parameters like
db_version,proxy_versionwhich are part of the API, but should be obfuscated from the external user. As discussed we're fine if users find out about them via reading the code, but reading the docs should not give hints about their existence.This will mainly be used for automated testing by internal teams.