Skip to content

Conversation

@ptiurin
Copy link
Contributor

@ptiurin ptiurin commented Feb 22, 2022

GitHub recently fixed relative workflow reference. It pulls whichever version of the dependent workflow is present on the current branch. Meaning we no longer need to swap workflow path each time we want to test a change on it on a branch
e.g. before - any changes to security-scan.yml would have to be tested by changing pull-request.yml to call security-scan.yml@ and then back to @ main. Now none of this is needed as workflows reference changes on a branch.

@ptiurin ptiurin requested a review from yuryfirebolt February 22, 2022 16:06
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

85.6% 85.6% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@yuryfirebolt yuryfirebolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, it would make stuff a bit easier

@ptiurin ptiurin merged commit c4ff6c4 into main Feb 23, 2022
@ptiurin ptiurin deleted the ci--Relative-workflow-paths branch February 23, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants