feat:Fir 11238 python sdk support new data types #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptiurin
reviewed
Mar 9, 2022
tests/unit/async_db/conftest.py
Outdated
| "1.0387398573", | ||
| "some text", | ||
| "2019-07-31", | ||
| "2020-07-31", |
There was a problem hiding this comment.
New dates extended the range below 1970 so let's reflect this in a test (despite it being a unit test) e.g. 1860-01-31, which was not possible with regular DATE
There was a problem hiding this comment.
Sure, agree
Comment on lines
-95
to
-96
| assert parse_value("2021-12-31 23:59:59", datetime) == datetime( | ||
| 2021, 12, 31, 23, 59, 59 |
There was a problem hiding this comment.
Should the same test be there for date32?
There was a problem hiding this comment.
date32 doesn't support milliseconds
There was a problem hiding this comment.
Oh, I see what you mean
yuryfirebolt
approved these changes
Mar 9, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for
decimal,date32anddatetime64types.Added unit tests and for decimal added integration tests