feat: Fir 11986 full support for set statement #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepansergeevitch
changed the title
ptiurin
approved these changes
Mar 16, 2022
src/firebolt/async_db/_types.py
Outdated
| return formatted_sql | ||
|
|
||
|
|
||
| Set = namedtuple("Set", ["name", "value"]) |
There was a problem hiding this comment.
Is there a way to avoid confusion with set in python? Same with typing.Set. Maybe Setting would be better? I'm open to other naming suggestions.
There was a problem hiding this comment.
I'm thinking of ParameterSet
There was a problem hiding this comment.
How about SetParameter then? This way it sounds just how we call them outside of code.
There was a problem hiding this comment.
Sure, fine with me
| and cursor._set_parameters["param"] == "1" | ||
| ) | ||
|
|
||
| cursor.flush_parameters() |
There was a problem hiding this comment.
Can we also add a test for multiple set paramter queries? Either executed separately or in the same statement. So then in the end _set_parameters contains both a and b.
There was a problem hiding this comment.
Yes, makes sense
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for set statements based on the design doc
https://docs.google.com/document/u/1/d/1tuo_zAbRYUog3OiW8duMYkivsQhi20gutCibxa5o5ic/edit
Added unit and integration tests.
Added deprecation warning for old way to pass set parameters