Skip to content

ci: Fir 12453 add security scans to nightly #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 5, 2022
Merged

ci: Fir 12453 add security scans to nightly #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9a1c60
fix nightly tests
stepansergeevitch Apr 4, 2022
93329a1
add security scans to nightly
stepansergeevitch Apr 4, 2022
5355027
fix nightly yml
stepansergeevitch Apr 4, 2022
ea64fc9
make engine names shorter
stepan-northspyre Apr 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@ on:
jobs:
code-check:
uses: ./.github/workflows/code-check.yml
unit-tests:
uses: ./.github/workflows/unit-tests.yml
security-scan:
needs: [unit-tests]
uses: ./.github/workflows/security-scan.yml
secrets:
FOSSA_TOKEN: ${{ secrets.FOSSA_TOKEN }}
SONARCLOUD_TOKEN: ${{ secrets.SONARCLOUD_TOKEN }}
tests:
runs-on: ${{ matrix.os }}
strategy:
Expand Down
17 changes: 10 additions & 7 deletions tests/integration/resource_manager/test_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import time
from collections import namedtuple

import pytest
Expand All @@ -12,10 +11,14 @@
)


def make_engine_name(database_name: str, suffix: str) -> str:
return f"{database_name}_{suffix}"


@pytest.mark.skip(reason="manual test")
def test_create_start_stop_engine():
def test_create_start_stop_engine(database_name: str):
rm = ResourceManager()
name = f"integration_test_{int(time.time())}"
name = make_engine_name(database_name, "start_stop")

engine = rm.engines.create(name=name)
assert engine.name == name
Expand All @@ -40,9 +43,9 @@ def test_create_start_stop_engine():


@pytest.mark.skip(reason="manual test")
def test_copy_engine():
def test_copy_engine(database_name):
rm = ResourceManager()
name = f"integration_test_{int(time.time())}"
name = make_engine_name(database_name, "copy")

engine = rm.engines.create(name=name)
assert engine.name == name
Expand Down Expand Up @@ -111,7 +114,7 @@ def get_engine_params(rm: ResourceManager, engine: Engine):
def test_engine_update_single_parameter(rm_settings: Settings, database_name: str):
rm = ResourceManager(rm_settings)

name = f"integration_test_{int(time.time())}"
name = make_engine_name(database_name, "single_param")
engine = rm.engines.create(name=name)

engine.attach_to_database(database=rm.databases.get_by_name(database_name))
Expand All @@ -130,7 +133,7 @@ def test_engine_update_single_parameter(rm_settings: Settings, database_name: st
def test_engine_update_multiple_parameters(rm_settings: Settings, database_name: str):
rm = ResourceManager(rm_settings)

name = f"integration_test_{int(time.time())}"
name = make_engine_name(database_name, "multi_param")
engine = rm.engines.create(name=name)

engine.attach_to_database(database=rm.databases.get_by_name(database_name))
Expand Down