Skip to content

feat: Add use_spot parameter to the engine update method #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2022
Merged

feat: Add use_spot parameter to the engine update method #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/firebolt/model/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,7 @@ def update(
auto_stop: Optional[int] = None,
warmup: Optional[WarmupMethod] = None,
description: Optional[str] = None,
use_spot: Optional[bool] = None,
) -> Engine:
"""
update the engine, and returns an updated version of the engine, all parameters
Expand Down Expand Up @@ -361,7 +362,7 @@ class _EngineUpdateRequest(FireboltBaseModel):

# Update the engine desired_revision if needed
desired_revision = None
if (scale or spec) and self.latest_revision_key:
if (scale or spec or use_spot is not None) and self.latest_revision_key:
rm = self._service.resource_manager
desired_revision = rm.engine_revisions.get_by_key(self.latest_revision_key)

Expand All @@ -381,6 +382,9 @@ class _EngineUpdateRequest(FireboltBaseModel):
if scale:
desired_revision.specification.db_compute_instances_count = scale

if use_spot is not None:
desired_revision.specification.db_compute_instances_use_spot = use_spot

update_mask_paths = list(
prune_dict(
{
Expand Down