feat(FIR-9997): Usage tracking #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepansergeevitch
approved these changes
Jun 7, 2022
src/firebolt/utils/usage_tracker.py
Outdated
| connectors = detect_connectors() | ||
| logger.debug("Detected running from packages: %s", str(connectors)) | ||
| # Override auto-detected connectors with info provided manually | ||
| if type(custom_connectors) == tuple: |
There was a problem hiding this comment.
What if someone would pass
(
("connector1", "version1"),
("connector2", "version2")
)
There was a problem hiding this comment.
Maybe let's just enforce passing a list? And don't allow passing a single item
yuryfirebolt
approved these changes
Jun 7, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking usage based on parsing the stack and detecting known integration signatures of file + function name.
Also allowing access for manual override/addition of connector information.
Addition of a UsageTracker instance to the Conection causes a diffferent garbage collection to trigger, therefore a warnings test also had to be reworked with a manual call to gc. Users still get a warning of an unclosed connection if their script exits without doing so. This change only affects how we test the warnings, not how the users of the SDK see them.