Skip to content

feat(FIR-14346): Separate client tracking #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2022
Merged

feat(FIR-14346): Separate client tracking #184

merged 2 commits into from
Jul 4, 2022

Conversation

ptiurin
Copy link
Contributor

@ptiurin ptiurin commented Jun 30, 2022

No description provided.

stepansergeevitch
stepansergeevitch approved these changes Jul 4, 2022
View reviewed changes
Copy link
Collaborator

@stepansergeevitch stepansergeevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please extend get_user_agent_header docstring describing the difference between drivers and clients arguments

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ptiurin ptiurin merged commit 71836d2 into main Jul 4, 2022
@ptiurin ptiurin deleted the feat-tracker-split branch July 4, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stepansergeevitch stepansergeevitch stepansergeevitch approved these changes

@yuryfirebolt yuryfirebolt Awaiting requested review from yuryfirebolt

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ptiurin @stepansergeevitch