feat: use trio for async_to_sync #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepansergeevitch
approved these changes
Nov 24, 2022
| async_job_thread = AsyncJobThread() | ||
| return async_job_thread.execute(f(*args, **kwargs)) | ||
| return loop.run_until_complete(f(*args, **kwargs)) | ||
| return trio.run(partial(f, *args, **kwargs)) |
Jupyter seems to be working fine as well. |
ptiurin
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asyncio prevents us from sharing Connection objects across threads due to registering httpx Client to the main thread's loop. Trio seems to solve this problem, as confirmed in the integration test I've added. Looks like there's no impact on the rest of the functionality.